DEPR: implicit resample in plotting #62433
Conversation
| data = data.tz_localize(None).to_period(freq=freq_str) | ||
| elif isinstance(data.index, ABCPeriodIndex): | ||
| data.index = data.index.asfreq(freq=freq_str, how="start") | ||
| # This will convert e.g. freq="60min" to freq="min", but will |
There was a problem hiding this comment.
this bit is unrelated, can revert and do it in a separate branch
mroeschke added Visualization 
| "will raise in a future version. Align series frequencies " | ||
| "before plotting instead.", |
There was a problem hiding this comment.
Could go as far to suggest f"Call series.resample('{freq}') ..."?
There was a problem hiding this comment.
Sure.
But now im wondering how much this will even help in moving towards #54485. In order to check if we're in this situation we still need the state information attached somehow.
I know "nuke it from space" isn't a viable approach to the plotting code, but it is really really bad.
| | ||
| msg = "Plotting with mixed-frequency series is deprecated" | ||
| with tm.assert_produces_warning(Pandas4Warning, match=msg): | ||
| s.plot(secondary_y=True) |
There was a problem hiding this comment.
it isn't clear to me why the warning is emitted here since ax isn't passed. if that keyword isn't the relevant factor in deciding if the statefulness is needed, then #62442 may not achieve its goals
| This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
2 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The use cases for this are all along the lines of
In this case,
ser2gets silently resampled (period-style, which is different from regular resample i think) so that the x-axis matches the plot forser1. (I think. We don't have any comments/docstrings explaining "why" for any of the plotting code).In these cases, "reindex yourself" is a totally valid workaround. Since this is a big use case for kludged state information, I'm hopeful it will move us in the direction of #54485 too.