Skip to content

small py3 fixes #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

small py3 fixes #6203

wants to merge 1 commit into from

Conversation

@metakermit
Copy link
Contributor

@metakermit metakermit commented Jan 31, 2014

@y-p correcting those small fixes I mentioned in the comments of your commit.
@ghost
Copy link

ghost commented Jan 31, 2014

Thanks, can you test 3d155cc on PY3?
@metakermit
Copy link
Contributor Author

metakermit commented Feb 1, 2014

Works, thanks! 👍
@metakermit metakermit closed this Feb 1, 2014
@ghost
Copy link

ghost commented Feb 1, 2014

Wait, so the docs compile on py3 now?
@metakermit
Copy link
Contributor Author

metakermit commented Feb 1, 2014

Yes, they do with the latest master.

(I see you added the fixes yourself)
@ghost
Copy link

ghost commented Feb 1, 2014

I thought the code examples were not py3 compat?
@ghost
Copy link

ghost commented Feb 1, 2014

Anyway, I'll test doc code fixes on PY3 in the future as to not break things again.
Thanks for reporting.
@metakermit
Copy link
Contributor Author

metakermit commented Feb 3, 2014

Yes, the code examples in the documentation are still not py3 compatible yet. I am just talking about the doc build process here.

OK, thanks, it would be great if you guys tested any changes to these sphinx extensions and the make.py script on Python 3 in the future (so that we don't have to redo the same work).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@metakermit