Skip to content

BUG: PeriodIndex.to_datetime inconsistent with its docstring #60350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

BUG: PeriodIndex.to_datetime inconsistent with its docstring #60350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
861d8cf
check how == 'S'
aram-cedarwood Oct 3, 2024
3dac96a
whatsnew
aram-cedarwood Oct 3, 2024
ea089e7
tests
aram-cedarwood Oct 6, 2024
63dabc5
Merge branch 'main' into periodindex-to_datetime_inconsistent_with_it…
aram-cedarwood Nov 16, 2024
eb44720
Merge branch 'main' into periodindex-to_datetime_inconsistent_with_it…
aram-cedarwood Nov 17, 2024
1432e75
freq='B' is deprecated? issue 53446
aram-cedarwood Nov 17, 2024
a43ade7
freq='B' is deprecated? issue 53446
aram-cedarwood Nov 18, 2024
1b02145
Merge branch 'main' into periodindex-to_datetime_inconsistent_with_it…
aram-cedarwood Nov 26, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
check how == 'S'
  • Loading branch information
@aram-cedarwood
aram-cedarwood committed Oct 3, 2024
commit 861d8cf9f7d428b09eafc794727b69b926f95ddc
9 changes: 8 additions & 1 deletion pandas/core/arrays/period.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,14 @@ def to_timestamp(self, freq=None, how: str = "start") -> DatetimeArray:

new_parr = self.asfreq(freq, how=how)

new_data = libperiod.periodarr_to_dt64arr(new_parr.asi8, base)
is_start = how == "S"
if is_start:
new_data = np.asarray(
Copy link
Member

@WillAyd WillAyd Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
new_data = np.asarray(
new_data = new_parr.dt.start_time

the list comprehension is going to be prohibitively slow (might be the cause of the current ASV failures). If you can use the vectorized datetimeindex (DTI) methods we have, I think that might fix things
Copy link
Contributor Author

@aram-cedarwood aram-cedarwood Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks @WillAyd, I'll have more time later to look into this, but for now...
new_parr.dt.start_time gives AttributeError: 'PeriodArray' object has no attribute 'dt'
new_parr.start_time gives RecursionError: maximum recursion depth exceeded while calling a Python object
[getattr(period, "start_time", period) for period in new_parr]
)
else:
new_data = libperiod.periodarr_to_dt64arr(new_parr.asi8, base)

dta = DatetimeArray._from_sequence(new_data, dtype=np.dtype("M8[ns]"))

if self.freq.name == "B":
Expand Down
12 changes: 12 additions & 0 deletions pandas/tests/indexes/period/methods/test_to_timestamp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,18 @@ def test_to_timestamp_1703(self):
result = index.to_timestamp()
assert result[0] == Timestamp("1/1/2012")

def test_cast_to_timestamps_at_beginning_of_period(self):
# GH 59371
index = period_range("2000", periods=3, freq="M")
result = index.to_timestamp("M")

expected = DatetimeIndex(
["2000-01-01", "2000-02-01", "2000-03-01"],
dtype="datetime64[ns]",
freq="MS",
)
tm.assert_equal(result, expected)


def test_ms_to_timestamp_error_message():
# https://github.com/pandas-dev/pandas/issues/58974#issuecomment-2164265446
Expand Down
Loading