Update getting_started.css #60027
Closed
Update getting_started.css #60027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The problem is "DOC: Intro to pandas table not readily visible in dark mode pandas-dev#60024" Perhaps we could set this part of the font color to blue, which is highly visible in either bright or dark mode, so that there is no need to implement a font color that changes with the theme.
rhshadrach requested changes Oct 13, 2024
I noticed that both Dev and 2.2 are built with PyData-Sphinx-theme 0.14.4, so maybe something else is wrong. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The problem is "DOC: Intro to pandas table not readily visible in dark mode #60024"
Perhaps we could set this part of the font color to blue, which is highly visible in either bright or dark mode, so that there is no need to implement a font color that changes with the theme.
So I made a very simple change in the documentation by setting the font color in .tutorial-card-header-2 to blue so that the font can be seen in either bright or dark mode.