added markDown Feature #60004
Closed
added markDown Feature #60004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke requested changes Oct 8, 2024
There was a problem hiding this comment.
Thanks for the PR, but we would require an issue to discuss the feature request (replacing tablulate with your implementation). This PR would also need to demonstrate that your function passes all the markdown tests.
IMO it's probably unlikely that this would be accepted into pandas since this would incur maintenance burden which was handled by tabulate. Might I suggest submitting a pull request to tabulate proposing your performance improvements
| Thank you that makes total sense to me. Appreciate the feedback and prompt reply. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I am new to adding features and working with anything this extensive. I didn't realize to_markdown() was a function so I made my own. It also doesn't require tabulate and is around 40% fasters in my tests. Looking forward to any feedback.