Skip to content

Enforce silent downcasting deprecation #57328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Enforce silent downcasting deprecation #57328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e0c2409
Enforce silent downcasting deprecation
phofl Feb 9, 2024
893d224
Update
phofl Feb 10, 2024
e6cf6ee
Update
phofl Feb 10, 2024
83d4210
Merge remote-tracking branch 'upstream/main' into silent_downcasting
phofl Feb 10, 2024
eec8fc4
Add whatsnew
phofl Feb 10, 2024
971386b
Fixup docstrings
phofl Feb 11, 2024
1837e2c
Merge remote-tracking branch 'upstream/main' into silent_downcasting
phofl Feb 11, 2024
0641f6b
Update
phofl Feb 11, 2024
833a334
Merge branch 'main' into silent_downcasting
phofl Feb 12, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions doc/source/reference/frame.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ Missing data handling
.. autosummary::
:toctree: api/

DataFrame.backfill
DataFrame.bfill
DataFrame.dropna
DataFrame.ffill
Expand All @@ -216,7 +215,6 @@ Missing data handling
DataFrame.isnull
DataFrame.notna
DataFrame.notnull
DataFrame.pad
DataFrame.replace

Reshaping, sorting, transposing
Expand Down
2 changes: 0 additions & 2 deletions doc/source/reference/series.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ Missing data handling
.. autosummary::
:toctree: api/

Series.backfill
Series.bfill
Series.dropna
Series.ffill
Expand All @@ -217,7 +216,6 @@ Missing data handling
Series.isnull
Series.notna
Series.notnull
Series.pad
Series.replace

Reshaping, sorting
Expand Down
4 changes: 2 additions & 2 deletions doc/source/user_guide/basics.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,8 +1308,8 @@ filling method chosen from the following table:
:header: "Method", "Action"
:widths: 30, 50

pad / ffill, Fill values forward
bfill / backfill, Fill values backward
ffill, Fill values forward
bfill, Fill values backward
nearest, Fill from the nearest index value

We illustrate these fill methods on a simple Series:
Expand Down
2 changes: 2 additions & 0 deletions doc/source/whatsnew/v2.2.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,8 @@ For example:

pd.date_range('2020-01-01', periods=3, freq='QE-NOV')

.. _whatsnew_220.silent_downcasting:

Deprecated automatic downcasting
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ Removal of prior version deprecations/changes
- :func:`read_excel`, :func:`read_json`, :func:`read_html`, and :func:`read_xml` no longer accept raw string or byte representation of the data. That type of data must be wrapped in a :py:class:`StringIO` or :py:class:`BytesIO` (:issue:`53767`)
- All arguments except the first ``path``-like argument in IO writers are now keyword only (:issue:`54229`)
- Changed the default value of ``observed`` in :meth:`DataFrame.groupby` and :meth:`Series.groupby` to ``True`` (:issue:`51811`)
- Enforced silent-downcasting deprecation for :ref:`all relevant methods <whatsnew_220.silent_downcasting>` (:issue:`54710`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the option still exists in config_init and it is set in 3 tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option will need to be deprecated in a follow up, but it can be removed in those tests
- Removed ``DataFrame.applymap``, ``Styler.applymap`` and ``Styler.applymap_index`` (:issue:`52364`)
- Removed ``DataFrame.bool`` and ``Series.bool`` (:issue:`51756`)
- Removed ``DataFrame.first`` and ``DataFrame.last`` (:issue:`53710`)
Expand Down
Loading