raise error on unsafe decimal parse with pyarrow types #56985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

mroeschke merged 6 commits into pandas-dev:main from rohanjain101:decimal_parse

Jan 23, 2024

Contributor

rohanjain101 commented Jan 20, 2024

closes BUG: Unsafe decimal parse for arrow types silently truncates value instead of raising an error #56984(Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Rohan Jain and others added 4 commits

January 20, 2024 13:06

raise error on unsafe decimal parse with pyarrow types

18582fd

fix min versions

50f883b

restore typeerrro

2dbafa7

Merge branch 'main' into decimal_parse

5b49f58

WillAyd reviewed

View reviewed changes

pandas/tests/extension/test_arrow.py Show resolved Hide resolved

pandas/tests/extension/test_arrow.py Show resolved Hide resolved

WillAyd added the Arrow label

Rohan Jain added 2 commits

January 22, 2024 09:06

success

9a84f4e

Merge branch 'decimal_parse' of https://github.com/rohanjain101/pandas …

daafa36

…into decimal_parse

WillAyd approved these changes

View reviewed changes

Member

WillAyd left a comment

lgtm - @mroeschke

mroeschke added this to the 3.0 milestone

mroeschke approved these changes

View reviewed changes

mroeschke merged commit c3fc9bb into pandas-dev:main

Member

mroeschke commented Jan 23, 2024

Thanks @rohanjain101

rohanjain101 deleted the decimal_parse branch

January 23, 2024 16:29

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request

raise error on unsafe decimal parse with pyarrow types (pandas-dev#56985

34f26d4

) * raise error on unsafe decimal parse with pyarrow types * fix min versions * restore typeerrro * success --------- Co-authored-by: Rohan Jain <rohanjain@microsoft.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment