implement mod and divmod for pyarrow types #56694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

rohanjain101 wants to merge 2 commits into pandas-dev:main from rohanjain101:pa_mod

Contributor

rohanjain101 commented Jan 1, 2024

closes BUG: mod and divmod raise NotImplementedError with pyarrow types #56693(Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Rohan Jain added 2 commits

January 1, 2024 01:30

implement mod and divmod for pyarrow types

542a413

cleanup

c45cb00

rohanjain101 commented

View reviewed changes

pandas/tests/extension/test_arrow.py

       tm.assert_series_equal(result, expected)  
    
    modulus_test_cases = [

Contributor Author

rohanjain101 Jan 1, 2024

Tests for large values should be added after #56676 is fixed.

Contributor Author

rohanjain101 commented Jan 1, 2024

Not overflow safe.

rohanjain101 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment