CLN: Remove unnecessary ExcelWriterMeta metaclass #5403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Only `__new__` is really necessary. And subclasses just have to deal with being passed an 'engine' keyword argument + a tad bit of style cleanup.
jtratner added a commit that referenced this pull request Nov 1, 2013
CLN: Remove unnecessary ExcelWriterMeta metaclass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Only
__new__is really necessary. And subclasses just have to deal withbeing passed an 'engine' keyword argument + a tad bit of style cleanup.
Thanks to @jseabold and @josef-pkt for making me realize that this was
unnecessary in statsmodels/statsmodels#1167
:)
@jmcnamara - this has completely trivial impact on ExcelWriter
subclasses, just removes some magic.