CLN: Add _reset_cache method to PandasObject #5238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| this is fine FYI - I realize that am using _cacher in NDFrame for the ref to the _item_cache but that's different anyhow |
Contributor Author
|
|
Contributor
| no this is consistent with the _cache holder (but I may change the other one now that I think about it) |
jtratner added a commit that referenced this pull request Oct 16, 2013
CLN: Add _reset_cache method to PandasObject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I think this is the right way to do it. MI needs this for _engine and
friends. I think there are other objects that use
cache_readonlythatmight want to reset too.
I also moved the local dir methods off of StringMixin to PandasObject
(where they ought to have been).
Fixes #5236 and fixes #5225.