48855 pylint import error

[slackline]

• Partially addresses STYLE fix pylint issues #48855 (Replace xxxx with the Github issue number)
• [N/A] Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• [N/A] Added type annotations to new arguments/methods/functions.
• [N/A] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

The huge number of errors that were reported by pre-commit that resulted in the disabling of the import-error message in the first place I think stem from the way in which pre-commit was configured to runpylint which was to use the action from the pylint repository. This meant a dedicated virtual environment was used and none of the packages in requirements-dev.txt were installed in the isolated virtual environment that is used (see pre-commit #157). The solution as described in the discussion of that thread (see comment) is to create a local hook and have it use the system environments pylint which is why .pre-commit-config.yaml has been modified.

In addition I have...

• Explicitly ignored versioneer.py from being linted because it is not a component of pandas and failed linting.
• Explicitly ignored ǜalidate_min_versions_in_sync.pyas it failed to import key libraries. Its a script used in anotherpre-commitlocal hook that checks minimum version of dependencies are aligned and not a componentpandas`.
• Added vulture as a required package to requirements-dev.py/ environment.yaml as it was the cause of some pylint import-error.
• Disabled the pylint import-error around...
  • import zoneinfo (and updated the code that checks for compatability with Python 3.9) in pandas/tests/indexes/datetimes/test_constructors.py.
  • from py.path import local as LocalPath in pandas/tests/io/excel/test_readers.py / pandas/tests/io/pytables/test_read.py / pandas/tests/io/sas/test_sas7bdat.py

[MarcoGorelli]

thanks for your PR

I think we should just not turn off this check, using language: system is unpredictable and I'd rather not risk breaking contributors' workflow

if there was an import error it'd be caught by the tests anyway

[slackline]

Closing as missing essential pylint package.

Oops, hadn't realised that adding a commit to my fork would make it through to here.

@MarcoGorelli : Ok not a problem, I don't have sufficient knowledge to comment on that. I'll leave it to others to decide.

[MarcoGorelli]

no worries, thanks anyway for your PR - closing then, but there's lot's of other issues to work on if you'd like