BUG/TST: Fix failing FRED comparison tests and remove skips. #4891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I removed this skip too. The initial failure was due to a revision in the official GDP data. It should be stable now for at least 5 years: http://blog.bea.gov/2013/07/23/comprehensive-revisions-nipa/
An alternative would be to use FRED's ALFRED which archives values so you can get the reported value at a given data.
jtratner added a commit that referenced this pull request Sep 20, 2013
BUG/TST: Fix failing FRED comparison tests and remove skips.
| just so you are aware...if you push a new branch with the same name as your PR branch, that's what Github uses. So if you ran : # delete fixfred3 remotely git push origin :fixfred3 git branch fixfred3 master git checkout fixfred3 git push -u origin fixfred3Then Github would pick up the change and use it for the PR. No magic involved. (though now it won't work because it's already been merged). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replacing my mess of a PR in #4890.
Fixes #4827
Assertions were being made about arrays (of one item) equaling
a scaler.