Skip to content

ENH: support downcasting of nullable EAs in pd.to_numeric #38746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 30, 2020
Merged

ENH: support downcasting of nullable EAs in pd.to_numeric #38746

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a594847
tests
arw2019 Dec 28, 2020
a1bb9fc
add NumericArray path in to_numeric
arw2019 Dec 28, 2020
dbba7b4
replace to_numpy use with _data
arw2019 Dec 28, 2020
ddb71cb
review comment
arw2019 Dec 28, 2020
323cfdc
more testcases
arw2019 Dec 28, 2020
7b4180e
Merge branch 'master' of https://github.com/pandas-dev/pandas into EA…
arw2019 Dec 28, 2020
337589a
whatsnew
arw2019 Dec 28, 2020
4e8761a
review comments
arw2019 Dec 28, 2020
e2b4cbb
cleanup
arw2019 Dec 28, 2020
23c4ae6
review comments (tests)
arw2019 Dec 28, 2020
e140b7a
more tests
arw2019 Dec 28, 2020
f583a10
de-duplicate testcae
arw2019 Dec 28, 2020
a6cb152
more cleanup
arw2019 Dec 28, 2020
d707a61
review: code comments
arw2019 Dec 30, 2020
6b2c39f
review: code comments
arw2019 Dec 30, 2020
fda4ba1
review: update docstring
arw2019 Dec 30, 2020
1a23118
review: reorder test parameters
arw2019 Dec 30, 2020
1015b07
review: add testcases
arw2019 Dec 30, 2020
0279be9
Merge branch 'master' of https://github.com/pandas-dev/pandas into EA…
arw2019 Dec 30, 2020
56747da
Update pandas/core/tools/numeric.py
arw2019 Dec 30, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review comments (tests)
  • Loading branch information
@arw2019
arw2019 committed Dec 28, 2020
commit 23c4ae6ad217f48baf55141f3eb037bfe3b944e7
3 changes: 3 additions & 0 deletions pandas/tests/tools/test_to_numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,12 +731,15 @@ def test_to_numeric_from_nullable_string(values, expected):
"data, input_dtype, downcast, expected_dtype",
(
([1, 1], "Int64", "integer", "Int8"),
([1.0, 1.0], "Float64", "integer", "Int8"),
([1, pd.NA], "Int64", "integer", "Int8"),
([450, 300], "Int64", "integer", "Int16"),
([1, 1], "Int64", "signed", "Int8"),
([1.0, 1.0], "Float32", "signed", "Int8"),
([1, pd.NA], "Int64", "signed", "Int8"),
([450, -300], "Int64", "signed", "Int16"),
([1, 1], "Int64", "unsigned", "UInt8"),
([1.0, 1.0], "Float32", "unsigned", "UInt8"),
([1, pd.NA], "Int64", "unsigned", "UInt8"),
([450, -300], "Int64", "unsigned", "Int64"),
([-1, -1], "Int32", "unsigned", "Int32"),
Expand Down