BUG&TST: HTML formatting error in Styler.render() in rowspan attribute #38533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback requested changes Dec 22, 2020
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
can you add a whatsnew note, bug fixes for 1.2 (add a Styler sub-section after Plotting). merge master and ping on green-ish.
jreback approved these changes Dec 22, 2020
Contributor
| lgtm ping on greenish |
Contributor Author
| The Travis check didn't pass and after checking why, I don't see a clear error on what went wrong. All the other checks did pass, can you help me with this? @jreback |
Contributor
| thanks @JoseNavy the travis CI is acting up, unrelated |
Contributor
| @meeseeksdev backport 1.2.x |
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 22, 2020
…r.render() in rowspan attribute
jreback pushed a commit that referenced this pull request Dec 22, 2020
… in rowspan attribute (#38640) Co-authored-by: JoseNavy <72418396+JoseNavy@users.noreply.github.com>
Closed
3 tasks
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff