TST: Test pivot_table() with categorical data #28803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ryankarlos force-pushed the Test-PivotTable-Categoricaldata branch from 44d09f9 to 3d485d2 Compare 
Contributor Author
| @jorisvandenbossche @jschendel Just had a go at this - let me know if any changes required |
jreback requested changes Oct 6, 2019
pandas/tests/reshape/test_pivot.py Outdated
| tm.assert_frame_equal(result, expected) | ||
| | ||
| def test_pivot_with_categorical(self): | ||
| # gh-21370 |
Contributor
There was a problem hiding this comment.
can you move this near def test_categorical_margins_category(self, observed) also if you can accept the observed fixture.
Contributor
There was a problem hiding this comment.
Can you also use the ordered_fixture instead of using ordered=True.
Contributor Author
There was a problem hiding this comment.
@topper-123 thanks, just added and pushed latest changes
jreback added Categorical 
ryankarlos force-pushed the Test-PivotTable-Categoricaldata branch from 8495a98 to f19e1bf Compare Contributor Author
| Don't know why CI is failing - not sure error is related to my PR |
…st-PivotTable-Categoricaldata
jreback requested changes Oct 8, 2019
| | ||
| def test_pivot_with_categorical(self, observed, ordered_fixture): | ||
| # gh-21370 | ||
| idx = [np.nan, "low", "high", "low", np.nan] |
Contributor
There was a problem hiding this comment.
you are not using observed here?
Contributor Author
There was a problem hiding this comment.
@jreback Do you mean pass as keyword arg to pivot_table() ? Ive just pushed changes
jreback approved these changes Oct 12, 2019
Contributor
| thanks @ryankarlos |
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff