Skip to content

Fix compilation on MSVC, signbit not in math.h #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix compilation on MSVC, signbit not in math.h #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/algos.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ cdef inline int int_max(int a, int b): return a if a >= b else b
cdef inline int int_min(int a, int b): return a if a <= b else b


cdef extern from "math.h":
cdef extern from "src/headers/math.h":
double sqrt(double x)
double fabs(double)
int signbit(double)
Expand Down
11 changes: 11 additions & 0 deletions pandas/src/headers/math.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#ifndef _PANDAS_MATH_H_
#define _PANDAS_MATH_H_

#if defined(_MSC_VER)
#include <math.h>
__inline int signbit(double num) { return _copysign(1.0, num) < 0; }
#else
#include <math.h>
#endif

#endif