Replaces Exceptions with ValueError in MultiIndex, closes #21770 #21780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback added Error Reporting 
jreback requested changes Jul 6, 2018
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
lgtm. you add a note in Other API breaking changes (technically this is slightly breaking, but no big deal). otherwise lgtm.
Codecov Report
@@ Coverage Diff @@ ## master #21780 +/- ## ========================================== + Coverage 91.95% 91.95% +<.01% ========================================== Files 160 160 Lines 49820 49820 ========================================== + Hits 45812 45813 +1 + Misses 4008 4007 -1
Continue to review full report at Codecov.
|
jreback approved these changes Jul 7, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff