Skip to content

CLN: clean up groupby / categorical #21753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2018
Merged

CLN: clean up groupby / categorical #21753

merged 2 commits into from
Jul 6, 2018

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Jul 5, 2018

xref #21151
@jreback jreback added Refactor Internal refactoring of code Groupby Categorical Categorical Data Type labels Jul 5, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 5, 2018
@jreback
Copy link
Contributor Author

jreback commented Jul 5, 2018

cc @WillAyd
cc @jschendel
@codecov
Copy link

codecov bot commented Jul 6, 2018

Codecov Report

Merging #21753 into master will decrease coverage by <.01%.
The diff coverage is 96.29%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #21753 +/- ## ========================================== - Coverage 91.93% 91.93% -0.01%  ========================================== Files 159 160 +1 Lines 49733 49737 +4 ========================================== + Hits 45721 45724 +3  - Misses 4012 4013 +1
Flag Coverage Δ
#multiple 90.3% <96.29%> (-0.01%) ⬇️
#single 41.99% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.93% <ø> (-0.09%) ⬇️
pandas/core/groupby/groupby.py 92.65% <100%> (-0.02%) ⬇️
pandas/core/groupby/categorical.py 95.65% <95.65%> (ø)
pandas/core/indexes/category.py 97.01% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24a950...5783ce1. Read the comment docs.
@jreback
Copy link
Contributor Author

jreback commented Jul 6, 2018

cc @TomAugspurger ok?
@jreback jreback merged commit e2f2e21 into pandas-dev:master Jul 6, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@jreback
CLN: clean up groupby / categorical (pandas-dev#21753)
10abc40 
xref pandas-dev#21151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Categorical Categorical Data Type Groupby Refactor Internal refactoring of code

2 participants

@jreback @TomAugspurger