Skip to content

DEPR: remove v018 resample compatibilitiy #20782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2018
Merged

DEPR: remove v018 resample compatibilitiy #20782

merged 1 commit into from
Apr 24, 2018

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Apr 21, 2018

closes #20554
@jreback jreback added Resample resample method Compat pandas objects compatability with Numpy or Python functions labels Apr 21, 2018
@jreback jreback added this to the 0.23.0 milestone Apr 21, 2018
@codecov
Copy link

codecov bot commented Apr 22, 2018 •
edited
Loading

Codecov Report

Merging #20782 into master will decrease coverage by 0.06%.
The diff coverage is 87.5%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #20782 +/- ## ========================================== - Coverage 91.84% 91.78% -0.07%  ========================================== Files 153 153 Lines 49305 49247 -58 ========================================== - Hits 45286 45203 -83  - Misses 4019 4044 +25
Flag Coverage Δ
#multiple 90.17% <87.5%> (-0.07%) ⬇️
#single 41.88% <12.5%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/resample.py 96.06% <87.5%> (-0.37%) ⬇️
pandas/plotting/_converter.py 63.2% <0%> (-3.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8def649...1a8ab25. Read the comment docs.
@jreback
Copy link
Contributor Author

jreback commented Apr 22, 2018

@jorisvandenbossche @TomAugspurger if any comments
jorisvandenbossche
jorisvandenbossche reviewed Apr 23, 2018
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just a small note on something I don't fully understand
@TomAugspurger
Copy link
Contributor

@jorisvandenbossche I don't see a note from you. Perhaps it wasn't submitted?
jorisvandenbossche
jorisvandenbossche reviewed Apr 24, 2018
View reviewed changes
pandas/core/resample.py

# API compat of allowed attributes
_deprecated_valids = _attributes + ['__doc__', '_cache', '_attributes',
'binner', 'grouper', 'groupby',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, didn't push the button probably :-)

My question was about the above _deprecated_valids: what was the purpose of them? At least before, those attributes did not raise any warning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you can probably ignore my comment, those attributes are "hided" from tab completion anyway, and didn't change for the rest. I suppose this was here before to prevent raising any warning on them?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was gymnastics to make all of this work
@jreback jreback merged commit 64564e8 into pandas-dev:master Apr 24, 2018
@jorisvandenbossche jorisvandenbossche mentioned this pull request Dec 2, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compat pandas objects compatability with Numpy or Python functions Resample resample method

3 participants

@jreback @TomAugspurger @jorisvandenbossche