Skip to content

BUG/TST: assure conversions of datetimelikes for object, numeric dtypes #19224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2018
Merged

BUG/TST: assure conversions of datetimelikes for object, numeric dtypes #19224

merged 1 commit into from
Jan 13, 2018

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Jan 13, 2018 •
edited
Loading

closes #19223
closes #12425
@jreback jreback added Datetime Datetime data dtype Reshaping Concat, Merge/Join, Stack/Unstack, Explode Timedelta Timedelta data type labels Jan 13, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 13, 2018
@jreback
Copy link
Contributor Author

jreback commented Jan 13, 2018

This is fixed as well (and present in <= 0.22.0), I thought we had an issue about this

In [1]: pd.DataFrame({'A': [1,2,3]}).astype('m8[s]').dtypes Out[1]: A timedelta64[s] dtype: object
@jreback jreback force-pushed the astype branch 2 times, most recently from 29fbc64 to 4c60c0a Compare January 13, 2018 16:24
@jreback jreback mentioned this pull request Jan 13, 2018
Closed
@jreback jreback force-pushed the astype branch 2 times, most recently from 3944674 to 05859f6 Compare January 13, 2018 17:26
@jreback jreback merged commit 0477880 into pandas-dev:master Jan 13, 2018
@codecov
Copy link

codecov bot commented Jan 13, 2018

Codecov Report

Merging #19224 into master will decrease coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #19224 +/- ## ========================================== - Coverage 91.53% 91.52% -0.01%  ========================================== Files 147 147 Lines 48797 48797 ========================================== - Hits 44664 44661 -3  - Misses 4133 4136 +3
Flag Coverage Δ
#multiple 89.89% <88.88%> (-0.01%) ⬇️
#single 41.6% <55.55%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals.py 94.5% <100%> (ø) ⬆️
pandas/core/dtypes/common.py 94.58% <100%> (+0.04%) ⬆️
pandas/core/dtypes/cast.py 88.35% <75%> (-0.31%) ⬇️
pandas/util/testing.py 84.2% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a3d3a...b953695. Read the comment docs.
@jreback jreback deleted the astype branch January 13, 2018 19:50
@jreback jreback mentioned this pull request Jan 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Datetime Datetime data dtype Reshaping Concat, Merge/Join, Stack/Unstack, Explode Timedelta Timedelta data type

1 participant

@jreback