offsets cleanup #18174
Closed
offsets cleanup #18174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Move trivial Tick methods to tslibs.offsets Standardize usage of self._offset over self.offset, with properties for backward compat
| Hello @jbrockmendel! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on November 08, 2017 at 17:32 Hours UTC |
jreback requested changes Nov 8, 2017
pandas/_libs/tslibs/offsets.pyx Outdated
| | ||
| class _Tick(object): | ||
| _inc = Timedelta(microseconds=1000) | ||
| _prefix = 'undefined' |
There was a problem hiding this comment.
i would make this None as it would hard fail if not defined (or you can make it NotImemenrsError)
| also add a note in perf for 0.22; as you make more changes u can add those issue numbers in (PR numbers) |
| There's a lot of upcoming work in offsets. Luckily it isn't all cut/paste, so it won't be quite the deluge of PRs. Going to put together a thorough set of asvs; will remove the optimization and make this pure-cleanup for now. |
jreback requested changes Nov 8, 2017
| return False | ||
| first_weekday, _ = tslib.monthrange(dt.year, dt.month) | ||
| if first_weekday == 5: | ||
| return dt.day == 3 |
| Yes …Sent from my iPhone On Nov 8, 2017, at 12:17 PM, Jeff Reback ***@***.***> wrote: @jreback requested changes on this pull request. In pandas/tseries/offsets.py: > @@ -1227,12 +1227,7 @@ def onOffset(self, dt): if self.normalize and not _is_normalized(dt): return False first_weekday, _ = tslib.monthrange(dt.year, dt.month) - if first_weekday == 5: - return dt.day == 3 is this the same logic? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. |
| linting issue & rebase |
| would like to have some benchmark asv's here as well. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is mostly a small cleanup of offsets, want to keep this fairly trivial diff from obscuring more important upcoming changes.
The two non-trivial things here are 1) implement
_Tickclass in offsets.pyx with the most basic of its methods and 2) optimization ofTick.__hash__. You'd be surprised how big a difference this particular optimization makes:Before:
After