Add documentation link to SettingWithCopyWarning #17672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback reviewed Sep 26, 2017
doc/source/indexing.rst Outdated
| The chained assignment warnings / exceptions are aiming to inform the user of a possibly invalid | ||
| assignment. There may be false positives; situations where a chained assignment is inadvertently | ||
| reported. | ||
| |
There was a problem hiding this comment.
I would move this to the top of the section and make it a note::
Codecov Report
@@ Coverage Diff @@ ## master #17672 +/- ## ========================================== - Coverage 91.27% 91.24% -0.03% ========================================== Files 163 163 Lines 49760 49808 +48 ========================================== + Hits 45416 45445 +29 - Misses 4344 4363 +19
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #17672 +/- ## ========================================== - Coverage 91.27% 91.24% -0.03% ========================================== Files 163 163 Lines 49760 49808 +48 ========================================== + Hits 45416 45445 +29 - Misses 4344 4363 +19
Continue to review full report at Codecov.
|
jreback requested changes Sep 28, 2017
doc/source/indexing.rst Outdated
| .. note:: | ||
| | ||
| The chained assignment warnings / exceptions are aiming to inform the user of a possibly invalid | ||
| assignment. There may be false positives; situations where a chained assignment is inadvertently |
There was a problem hiding this comment.
remove the last sentence; this is actually not true. All purported false positive are actually user error (at least that have been reported)
#17505 Signed-off-by: Gábor Lipták <gliptak@gmail.com>
| @jreback Please review. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#17505
git diff upstream/master -u -- "*.py" | flake8 --diff