Skip to content

Make pd.Period immutable #17239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 24, 2017
Merged

Make pd.Period immutable #17239

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
89cf9d6
Make Period ordinal and freq readonly
jbrockmendel Aug 12, 2017
e6ca02c
Tests for Period immutability
jbrockmendel Aug 12, 2017
8912283
Trim whitespace
jbrockmendel Aug 13, 2017
d33922f
flake8 whitespace fixup
jbrockmendel Aug 13, 2017
b86a7b9
Add note in whatsnew; address reviewer requests
jbrockmendel Aug 19, 2017
1c6f197
flake8 whitespace fixup
jbrockmendel Aug 20, 2017
08a218c
Merge branch 'master' into period_immutable
jbrockmendel Aug 20, 2017
2642366
More brevity
jbrockmendel Aug 20, 2017
6c461eb
Merge branch 'period_immutable' of https://github.com/jbrockmendel/pa…
jbrockmendel Aug 20, 2017
0e62865
Merge branch 'master' into period_immutable
jbrockmendel Aug 22, 2017
cd687bf
Remove message per reviewer suggestion
jbrockmendel Aug 23, 2017
dc2111c
unwrap line per reviewer request
jbrockmendel Aug 23, 2017
1e92344
Merge branch 'period_immutable' of https://github.com/jbrockmendel/pa…
jbrockmendel Aug 23, 2017
19567c8
Try to guess what jreback wants
jbrockmendel Aug 23, 2017
f739f8f
move whatsnew to correct location
jreback Aug 24, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tests for Period immutability
  • Loading branch information
@jbrockmendel
jbrockmendel committed Aug 12, 2017
commit e6ca02cb2c036da35a61fc5a6bfc24a62d789366
11 changes: 11 additions & 0 deletions pandas/tests/test_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,3 +248,14 @@ def test_empty_like(self):
expected = np.array([True])

self._check_behavior(arr, expected)



def test_period_immutable():
per = pd.Period('2014Q1')
Copy link
Contributor

@jreback jreback Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number here. move test to tests for period scalars.
Copy link
Member Author

@jbrockmendel jbrockmendel Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.
with pytest.raises(AttributeError, message="is not writable"):
per.ordinal = 14

freq = per.freq
with pytest.raises(AttributeError, message="is not writable"):
per.freq = 2*freq