MAINT: Remove self.assertEqual from testing #16169
Conversation
gfyoung force-pushed the assert-equal-remove branch from 7b5fd16 to 1c69060 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #16169 +/- ## ========================================== - Coverage 90.86% 90.86% -0.01% ========================================== Files 162 162 Lines 50819 50821 +2 ========================================== Hits 46177 46177 - Misses 4642 4644 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #16169 +/- ## ========================================== + Coverage 90.86% 90.88% +0.02% ========================================== Files 162 162 Lines 50819 50821 +2 ========================================== + Hits 46177 46190 +13 + Misses 4642 4631 -11
Continue to review full report at Codecov.
|
jreback left a comment
jreback left a comment There was a problem hiding this comment.
a couple of places where I actually want to assert that i am getting a boolean back
use assert is False
| result = pd.eval('x', engine=self.engine, parser=self.parser) | ||
| self.assertEqual(result, False) | ||
| assert not result | ||
| assert is_scalar(result) |
There was a problem hiding this comment.
assert result is False
if the test is actually expecting False and not just Falsey
| frame = DataFrame(mat2, columns=['A', 'B', 'C'], index=[1, 2]) | ||
| self.assertEqual(True, frame['A'][1]) | ||
| self.assertEqual(False, frame['C'][2]) | ||
| assert frame['A'][1] |
gfyoung force-pushed the assert-equal-remove branch from 1c69060 to bfc963c Compare 
| Travis is failing for reasons that I don't understand....see here. |
| do those work locally? you can just revert that module/file for now and debug / followup after . |
| @jreback : Yes, they do. I walked through the code myself. Also, the |
| @jreback : You know what I can do: I can check |
gfyoung force-pushed the assert-equal-remove branch from bfc963c to 9fb41da Compare | @jreback : Workaround succeeded. Everything is green. |
| map = map | ||
| zip = zip | ||
| filter = filter | ||
| intern = sys.intern |
There was a problem hiding this comment.
this is fine
but where is it used?
There was a problem hiding this comment.
I stumbled upon it in a test (test_util.py), so I added this to compat for that reason.
| thanks! |
2 participants
Title is self-explanatory. Massive, massive PR.
Partially addresses #15990.