msgpack supports CategoricalIndex #15493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback requested changes Feb 23, 2017
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
you edit pandas/doc/source/whatsnew/v0.20.0.txt for this Bug Fix
pandas/tests/msgpack/test_unpack.py Outdated
| unpacker.feed(packb({'a': ExtType(2, b'321')}, encoding='utf-8')) | ||
| assert unpacker.unpack() == {'a': ExtType(2, b'321')} | ||
| | ||
| def test_unpack_categorical_index(self): |
Contributor
There was a problem hiding this comment.
the tests are all in pandas/tests/io/test_packers.py (this section is for the c-code that implements msgpack itself).
Contributor
There was a problem hiding this comment.
just follow examples there for style
Contributor Author
There was a problem hiding this comment.
Thanks, I tried to change the it accordingly. Do you get a notification if I push new commits? Or should I comment?
jreback added Compat jreback approved these changes Feb 23, 2017
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
small comments ping when all green
pandas/tests/io/test_packers.py Outdated
| result = read_msgpack(s) | ||
| tm.assert_frame_equal(result, df) | ||
| | ||
| df2 = df.astype({0: 'category'}).set_index(0) |
Contributor
There was a problem hiding this comment.
make a new test function
add the issue number as a comment
doc/source/whatsnew/v0.20.0.txt Outdated
| - Bug in ``Series.replace`` and ``DataFrame.replace`` which failed on empty replacement dicts (:issue:`15289`) | ||
| - Bug in ``pd.melt()`` where passing a tuple value for ``value_vars`` caused a ``TypeError`` (:issue:`15348`) | ||
| - Bug in ``.eval()`` which caused multiline evals to fail with local variables not on the first line (:issue:`15342`) | ||
| - Bug in ``DataFrame.read_msgpack`` which did not allow to load DataFrames with a CategoricalIndex (:issue:`15487`) |
Contributor
| thanks! |
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
closes pandas-dev#15487 Author: Arco Bast <arco.bast@yahoo.de> Closes pandas-dev#15493 from abast/CategoricalIndex_msgpack and squashes the following commits: c1c68e4 [Arco Bast] corrections 3c1f2e7 [Arco Bast] whatsnew 215c2aa [Arco Bast] improve tests cd9354f [Arco Bast] improve tests 7895c16 [Arco Bast] flake8 f3f492a [Arco Bast] fix test 91d85cb [Arco Bast] msgpack supports CategoricalIndex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThis allows
read_msgpackto read DataFrames with a categorical index. I'd assume that my testcase needs some improvement. Where can I find some information where and how to add the "whatsnew entry"?