CLN: split off frozen (immutable) data structures into pandas/indexes/frozen.py #15477
+231 −189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback added the Compat 
jorisvandenbossche approved these changes Feb 22, 2017
Member
jorisvandenbossche left a comment
jorisvandenbossche left a comment There was a problem hiding this comment.
Looks good (apart from the pickle failures)
pandas/compat/pickle_compat.py Outdated
| # our Unpickler sub-class to override methods and some dispatcher | ||
| # functions for compat | ||
| base_class = pkl._Unpickler if compat.PY3 else pkl.Unpickler | ||
| class Unpickler(base_class): |
Codecov Report
@@ Coverage Diff @@ ## master #15477 +/- ## ========================================== + Coverage 90.36% 90.36% +<.01% ========================================== Files 135 136 +1 Lines 49519 49532 +13 ========================================== + Hits 44747 44759 +12 - Misses 4772 4773 +1
Continue to review full report at Codecov.
|
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
…/frozen.py should make it a bit easier to work with these; and no reason to be in pandas/core/base.py Author: Jeff Reback <jeff@reback.net> Closes pandas-dev#15477 from jreback/frozen and squashes the following commits: 2a64a4f [Jeff Reback] CLN: split off frozen (immutable) data structures into pandas/indexes/frozen.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
should make it a bit easier to work with these; and no reason to be in pandas/core/base.py