Type levels as list in _make_concat_multiindex (fixes #14438) #14449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Current coverage is 85.25% (diff: 100%)@@ master #14449 diff @@ ========================================== Files 140 140 Lines 50631 50631 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== Hits 43166 43166 Misses 7465 7465 Partials 0 0
|
jreback requested changes Oct 19, 2016
pandas/tools/merge.py Outdated
Contributor
There was a problem hiding this comment.
change this in factorize_from_iterable instead
Contributor
| minor change, ping when green. |
Contributor Author
| yep, will do! |
…om_iterables (fixes pandas-dev#14438)
Contributor Author
| @jreback done! |
jreback approved these changes Oct 20, 2016
Contributor
| thanks @dubourg |
tworec pushed a commit to RTBHOUSE/pandas that referenced this pull request Oct 21, 2016
jorisvandenbossche pushed a commit that referenced this pull request Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff