Bug: Grouping by index and column fails on DataFrame with single index (GH14327) #14428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
4 tasks
Current coverage is 85.26% (diff: 96.29%)@@ master #14428 diff @@ ========================================== Files 140 140 Lines 50639 50649 +10 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 43177 43186 +9 - Misses 7462 7463 +1 Partials 0 0
|
Contributor Author
| @jreback it's green |
Contributor
| @jmmease can you make the doc-string updates. |
jreback reviewed Oct 15, 2016
doc/source/whatsnew/v0.19.1.txt Outdated
jreback reviewed Oct 15, 2016
pandas/indexes/base.py Outdated
Contributor
There was a problem hiding this comment.
this should match the doc-string of the MultiIndex. ( best to use a shared_doc to avoid repeating doc-strings)
added 13 commits October 15, 2016 12:20
Existing logic under "if level is not None:" assumed that index was a MultiIndex. Now we check and also handle the case where an Index is passed in with a None grouper. This resolves GH 14327
…red_doc (GH 14327)
Contributor Author
| @jreback Made documentation updates and then rebased to resolve conflict in whatsnew 0.19.1. |
jreback approved these changes Oct 15, 2016
Contributor
| lgtm ping on green |
Contributor Author
| @jreback green |
Member
| @jmmease Thanks! |
tworec pushed a commit to RTBHOUSE/pandas that referenced this pull request Oct 21, 2016
…x (GH14327) (pandas-dev#14428) Existing logic under "if level is not None:" assumed that index was a MultiIndex. Now we check and also handle the case where an Index is passed in with a None grouper. This resolves GH 14327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThis PR is a continuation of #14333. See discussion there for explanation of why this new PR was needed.