Skip to content

Conversation

@chris-b1
Copy link
Contributor

@chris-b1 chris-b1 commented Oct 6, 2016

Currently the cython cache on travis doesn't pick up change in .pxd files Most of this commit history is trial and error - but 479c311 shows this working

https://travis-ci.org/pydata/pandas/jobs/166041112

$ ci/prep_cython_cache.sh cython_files.tar motd.legal-displayed pip pyxfiles Cache available - checking pyx diff util.pxd has changed: --- /home/travis/build/pydata/pandas/pandas/src/util.pxd 2016-10-08 13:01:48.255250369 +0000 +++ /home/travis/.cache/pyxfiles/home/travis/build/pydata/pandas/pandas/src/util.pxd 2016-10-06 11:04:00.000000000 +0000 @@ -97,5 +97,6 @@ cdef inline bint _checknan(object val): return not cnp.PyArray_Check(val) and val != val + cdef inline bint is_period_object(object val): return getattr(val, '_typ', '_typ') == 'period' In a PR Rebuilding cythonized files Use cache (Blank if not set) = true Clear cache (1=YES) = 1 

xref #14359

@chris-b1 chris-b1 changed the title {WIP}dummy commit {WIP} BLD: cython cache pxd files Oct 6, 2016
@chris-b1 chris-b1 added Build Library building on various platforms CI Continuous Integration labels Oct 6, 2016
@codecov-io
Copy link

codecov-io commented Oct 6, 2016

Current coverage is 85.26% (diff: 100%)

Merging #14363 into master will not change coverage

@@ master #14363 diff @@ ========================================== Files 140 140 Lines 50632 50632 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== Hits 43170 43170 Misses 7462 7462 Partials 0 0 

Powered by Codecov. Last update 96b364a...479c311

@chris-b1 chris-b1 changed the title {WIP} BLD: cython cache pxd files BLD/CI: cython cache pxd files Oct 8, 2016
@chris-b1
Copy link
Contributor Author

@jreback, @jorisvandenbossche - if you wouldn't mind taking a look

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Oct 12, 2016
@jorisvandenbossche jorisvandenbossche merged commit 1369e12 into pandas-dev:master Oct 12, 2016
@jorisvandenbossche
Copy link
Member

@chris-b1 Thanks!

yarikoptic added a commit to neurodebian/pandas that referenced this pull request Oct 13, 2016
* commit 'v0.19.0-14-ga40e185': (37 commits) BUG: Bug in localizing an ambiguous timezone when a boolean is passed Convert readthedocs links for their .org -> .io migration for hosted projects (pandas-dev#14406) DOC: formatting in basics.rst BLD/CI: cython cache pxd files (pandas-dev#14363) BUG: set_levels set illegal levels. (pandas-dev#14236) DOC: add whitespace to v0.19.1 bug fix section change impl details slightly for pandas-dev#14292 BUG: Fix concat key name DOC: add 0.19.1 whatsnew file (pandas-dev#14366) DOC: to_csv warns regarding quoting behaviour for floats pandas-dev#14195 (pandas-dev#14228) DOC: fix formatting issue with msgpack table TST: pandas-dev#14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit docs: Remove old warning from dsintro.rst (pandas-dev#14365) DOC: minor v0.19.0 whatsnew corrections RLS: v0.19.0 DOC: update release notes DOC: Latest fixes for whatsnew file to_latex encoding follows the documentation (py2 ascii, py3 utf8) (pandas-dev#14329) DOC: fix some sphinx build issues (pandas-dev#14332) TST: fix period tests for numpy 1.9.3 (GH14183) (pandas-dev#14331) ...
tworec pushed a commit to RTBHOUSE/pandas that referenced this pull request Oct 21, 2016
@chris-b1 chris-b1 deleted the cython-cache branch November 30, 2016 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Library building on various platforms CI Continuous Integration

4 participants