Cid/dataset column validations #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
whoseoyster requested changes Sep 29, 2022
gustavocidornelas force-pushed the cid/dataset-column-validations branch from db17ec6 to 4665c11 Compare whoseoyster approved these changes Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new validations for datasets:
supported_dtypes.Both validations were already happening in the backend. This PR adds them to the Python API to fail early.
There is a related PR for the backend here.
Testing
Locally, introducing problems with the dataset that make the validations fail.
Examples:
1.