Completes UNB-2896 - Add consistency check between module versions us… #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gustavocidornelas force-pushed the cid/env-validation branch from 180b2c5 to b11d661 Compare 
whoseoyster approved these changes Sep 29, 2022
openlayer/__init__.py Outdated
| import pkg_resources | ||
| from bentoml.saved_bundle import bundler | ||
| from bentoml.utils import tempdir | ||
| from pkg_resources import DistributionNotFound, VersionConflict |
There was a problem hiding this comment.
follow google style guide on module level imports only
There was a problem hiding this comment.
fixed, thanks!
gustavocidornelas force-pushed the cid/env-validation branch from b11d661 to 5eb1101 Compare …ed in the Jupyter notebook and the ones specified in the requirements file
gustavocidornelas force-pushed the cid/env-validation branch from 5eb1101 to c4477e3 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…ed in the Jupyter notebook and the ones specified in the requirements file
Summary
Throws a warning if there are inconsistencies between the dependencies specified by in the
requirements_txt_fileand the modules installed in the notebook's env.Sample warnings
If there is a dependency in
requirements_txt_filethat is not installed in the current env (in this case, the modulepymupdf):If there are version conflicts:
Testing
Churn notebook, running locally.