Skip to content

fix: verify SSL by default and disable it via env var #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

fix: verify SSL by default and disable it via env var #453

merged 1 commit into from
Apr 15, 2025

Conversation

@gustavocidornelas
Copy link
Contributor

@gustavocidornelas gustavocidornelas commented Apr 15, 2025

Summary

  • I believe the previous SSL disabling verification logic was backwards.
  • The SSL verification should be the default behavior. Users can turn it off (in special situations) via env variables.
@whoseoyster whoseoyster merged commit 5058808 into main Apr 15, 2025
2 checks passed
@whoseoyster whoseoyster deleted the cid/verify-ssl-bug branch April 15, 2025 14:19
@gustavocidornelas gustavocidornelas mentioned this pull request Apr 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@gustavocidornelas @whoseoyster