Cid/requirements txt #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
whoseoyster requested changes Aug 8, 2022
unboxapi/__init__.py Outdated
| model_type: ModelType, | ||
| class_names: List[str], | ||
| requirements_txt_file: Optional[str] = None, | ||
| requirements_txt_file: str = None, |
There was a problem hiding this comment.
= None should be removed
| Can you add to the CHANGELOG? |
| Can you update https://github.com/unboxai/unboxapi-python-client/blob/0d2ad93a3f8bd0445fa1d78f7fc40226283c13ec/unboxapi/models.py#L121 to remove the if / else? |
…n uploading a model [Python API]
….py, pip install unboxapi for fetal health examples
gustavocidornelas force-pushed the cid/requirements-txt branch from 8862e74 to d5ea98a Compare whoseoyster approved these changes Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
requirements_txt_filea required argument onadd_models. To do so, removed theOptionaltype annotation and updated the marshmallow schema, so users can no longer upload models without it;requirements.txtfiles.About the new requirements files
I curl the requirements file from the
examples-galleryrepo. This is needed to make the notebooks work well on Google Colab. Since some of the requirements files are not yet onexamples-gallery(they'll be there once this PR is merged intomain), some of the curled links will be broken. Everything should work after the merge.Testing
I briefly tested all notebooks. Due to time constraints, I couldn't test the envs defined by the
requirements.txtas thoroughly as I wanted to. I did test the trickiest ones, such as the one forpytorch, which requires some more specific module versions.