Client side changes to support tasktype being a property of projects now #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
whoseoyster approved these changes Jul 30, 2022
whoseoyster requested changes Jul 30, 2022
| It all lgtm, other than a few prints! With respect to the notebooks, to be fully honest, I would try to update them all now. A lot has changed in the new version and I don't think we can expect to be able to merge anything (given that they are jupyter notebooks). Personally, I would just wait until all the API / backend changes go through and then we can manually include the task type on the examples. |
whoseoyster approved these changes Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Two main changes:
create_or_load_projectconvenience method to the clientTesting