Skip to content

Conversation

bjdooi
Copy link
Contributor

@bjdooi bjdooi commented Sep 11, 2024

Linked issue/ticket

Description

Adding in some extra MUI component as a styled text wrapper for "no content found" messages. Removing the "Results" component abstraction as it only hinders our ability to move components around. Moved "Pattern Search" right below "Information on found Panels" for a more visually fulfilling experience.

The last thing to do would be to fix some box shadow junk.... Maybe

Reproduction steps

Checklist

  • [✅] I've followed the Contributing guidelines
  • [✅] I've titled my PR according to the Conventional Commits spec
  • [✅] I've added tests that fail without this PR but pass with it
  • [✅] I've linted, tested, and commented my code
  • [✅] I've updated documentation (if appropriate)
…e and is a bit of an extra step when we all kind of already understand that we'll just slap extra look ups as their own component in tabPanels.tsx. Inconsequential removal of results.tsx as it was only referenced in a single location as well
…efactor this later to eliminate repeated code but speed is king right now. I feel pretty satisfied with the way search results look now
Copy link
Contributor

@joyceoh joyceoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked styling with will

@joyceoh joyceoh merged commit 4f62e7c into dev Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants