Skip to content

Conversation

bjdooi
Copy link
Contributor

@bjdooi bjdooi commented Sep 11, 2024

Linked issue/ticket

Description

  • Handling merge conflicts that came from file formatting and additional comments
  • Bug fixes for certain edge cases, added in if conditionals for component rendering edge cases
  • Slight style changes

Reproduction steps

Checklist

  • [✅] I've followed the Contributing guidelines
  • [✅] I've titled my PR according to the Conventional Commits spec
  • [✅] I've added tests that fail without this PR but pass with it
  • [✅] I've linted, tested, and commented my code
  • [✅] I've updated documentation (if appropriate)
…nal comments - Bug fixes for certain edge cases, added in if conditionals for component rendering edge cases - Slight style changes Merge branch 'dev' into telemetry-checks-bug-fixes # Conflicts: #	src/panel/components/searchResultComponents/telemetrySearchResults.tsx #	src/panel/components/tabPanels.tsx #	src/panel/panelApp.tsx #	src/workers/networkRequestFinder.ts
Copy link
Contributor

@allisonrm95 allisonrm95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to dependencyChecker.tsx, patternInfo.tsx, patternSearchResults.tsx, telemetrySearchResults.tsx, tabPanels.tsx, panelApp.tsx, and networkRequestFinder.ts all look great. Network requests are more narrowly focused providing more accurate and useful results. Edge cases were added in for components where no results are found. Console.logs were cleaned up. Functionality was maintained.

@allisonrm95 allisonrm95 merged commit a42531b into dev Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants