Skip to content

Conversation

joyceoh
Copy link
Contributor

@joyceoh joyceoh commented Sep 10, 2024

Description

Using OSV API to check the package.json both (dev)-dependencies. Frontend hyperlinked to vulnerabilities description from github.

Reproduction steps

added functionality first by finding json file
did API call to the found dependencies by parsing the JSON file
sent to front end
formatted to attach link and section off packages
response also for when no packages are found

Checklist

  • I've followed the Contributing guidelines
  • I've titled my PR according to the Conventional Commits spec
  • I've added tests that fail without this PR but pass with it
  • I've linted, tested, and commented my code
  • I've updated documentation (if appropriate)
Copy link
Contributor

@allisonrm95 allisonrm95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to tabPanels.tsx, panelApp.tsx, types.ts, and fileFinder.ts look great, as well as the new dependencyChecker.tsx file. They add in dependency checker functionality and maintain functionality. Code was cleaned before pulling.

@allisonrm95 allisonrm95 merged commit a99f0f1 into dev Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants