Skip to content

Conversation

bjdooi
Copy link
Contributor

@bjdooi bjdooi commented Sep 10, 2024

Linked issue/ticket

Description

Adding in telemetry checks- it looks through extensions for http requests and builds them out using ASTs. Once we find
a node we keep track of its position and are able to link it back to its original location.

This merge also includes a refactor of "panel" and makes it a panel unique to pattern match searches. Other searches
should also probably follow their own structure for now

Reproduction steps

This is a feature just added onto our base scan, so run a scan as normal

Checklist

  • [✅] I've followed the Contributing guidelines
  • [✅] I've titled my PR according to the Conventional Commits spec
  • [✅] I've added tests that fail without this PR but pass with it
  • [✅] I've linted, tested, and commented my code
  • [✅] I've updated documentation (if appropriate)
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/acorn-walk@8.3.4 None +1 590 kB adrianheine, marijn, rreverser

View full report↗︎

Copy link
Contributor

@allisonrm95 allisonrm95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates to components within the panel folder look great and maintain functionality. Renamed variables are more semantic. The new networkRequestFinder.ts file looks great and is imported accurately where needed.

@allisonrm95 allisonrm95 merged commit 4fd9414 into dev Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants