Skip to content

Sidebar cleanup #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2024
Merged

Sidebar cleanup #14

merged 2 commits into from
Sep 9, 2024

Conversation

sethjholl07
Copy link
Collaborator

Description

Fixed the identified edge cases

  1. If no extensions are selected and Scan extensions is clicked, error message pops up "No extensions selected".
  2. If an extensions is checked and then unchecked, the extension is removed from the scan.
  3. Once "Scan Extensions" is clicked, all the checked boxes uncheck.
allisonrm95
allisonrm95 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@allisonrm95 allisonrm95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to sidebarApp.tsx look great. They prevent extensions from remaining in the selected state and prevent users from opening a window without selecting any extensions.
@allisonrm95 allisonrm95 merged commit c5301ec into dev Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sethjholl07 @allisonrm95