Skip to content

fix: final sidebar cleanup #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: final sidebar cleanup #13

merged 1 commit into from
Sep 6, 2024

Conversation

sethjholl07
Copy link
Collaborator

Description

Cleaned up the sidebar panel functionality - removed unnecessary functions, made names more semantic, added comments explaining functionality.
allisonrm95
allisonrm95 reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@allisonrm95 allisonrm95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed sidebarApp.tsx, sidebarIndex.html, sidebarIndex.tsx and all changes look good. This adds multiple select functionality to the sidebar view while maintaining command execution and communication between webviews.
allisonrm95
allisonrm95 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@allisonrm95 allisonrm95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved changes, reasoning listed in previous comment.
@allisonrm95 allisonrm95 merged commit 96a0dbe into dev Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sethjholl07 @allisonrm95