Skip to content

Conversation

@sarhiri
Copy link
Contributor

@sarhiri sarhiri commented May 13, 2024

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would cause existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • When metrics are shows to be selected for display, there was no search or filter capability.

Approach

  • Updated MUI grid
  • Installed MUI grid toolbar quick filter
  • Manually updated broken states that were incompatible with upgrade

Learning

Screenshot(s)

Screenshot 2024-05-13 at 2 51 42 PM
seantokuzo and others added 30 commits December 21, 2023 08:51
implementing createItem functionality
services hooked - chronos configured but not working
added service name when connected to each PORT
add dotenv and chronos config to event-bus
mdtagg and others added 26 commits May 9, 2024 15:52
The system information coming from si was strangley not being passed to through the function. The function was being called syncronously and because all the si function are async the return at the end of the function was always passing an empty array. This is because although the data from si was coming in, it was being pushed into an empty array defined at the top of the file inside of a .then and becuase the return was executing synchrounously the array was never being updated. Added awaits to each of the si functions and now the data is moving again
refactoring the mongo.health function The data from health metrics was not being passed out and there is now an error with duplicate mongo entries
The filter on the health data array now checks for null values. This resulted in an error since we were inputting multiple nulls into the same db.
Prior to this change new metrics were added based on the an arbitrary length variable that was changed after the awaiting a find call to the mongo db. Current metrics is now queried directly. Two layers of awaits are still necessary when calling the find on the metrics db due to the queueing of all the await calls by the different services. Am looking in to making it more streamm line
Moved the metrics model find function inside the health metrics function so that the data from the metrics model is populated before the length check between the current metrics and the health metrics
Current metrics is only needed within this function to compare the lengths between current metrics and health metrics. Instead of grabbging current metrics outside of the function it is now grabbing the current metrics data before the length check.
Upon load of the graphscontainer component an event call is made to electron (health request) which calls the mongo fetch function which grabs all the health data stored inside of the individual services databases. Inside of the mongoFetch function there is a call for the grafana api key database. In the microservices portion of the app grafana is not used so there is no key. This was causing an error and preventing data flow. This portion is being commented out temporarily so that more specific controls can be made to differentiate between apps that use docker (and thus grafana) and microservices
@sarhiri sarhiri marked this pull request as draft May 13, 2024 21:12
@mdtagg mdtagg deleted the search-metrics branch May 15, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

8 participants