Skip to content

Conversation

@phcarval
Copy link
Contributor

Description

Adding the classification result to the segmented image as discussed in #1142

image

Changes

Describe the changes you made
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Ensure that you followed the following
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas (If applicable)
  • I have made corresponding changes to the documentation (If applicable)
  • I have added tests that prove my fix is effective or that my feature works (If applicable)
@samet-akcay
Copy link
Contributor

@blaz-r would you like to have a look at this

@blaz-r
Copy link
Contributor

blaz-r commented Sep 28, 2023

@samet-akcay sure.

@blaz-r
Copy link
Contributor

blaz-r commented Sep 28, 2023

@phcarval thank you for dressing this. I like the clean solution that nicely uses existing code 😃. One thing that we discussed was an idea to instead add text bellow the figure. Something like the following:
image
This way, it can't happen that the segmentation result is obstructed. Do you think that this might be a better solution?

@phcarval
Copy link
Contributor Author

Yes indeed! I thought about that issue. I am quite busy at the moment so not sure I can get this done soon though.

@blaz-r
Copy link
Contributor

blaz-r commented Sep 28, 2023

No problem. Take your time ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants