Replace all occurences of np.str by builtin python str #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Felix Marty <9808326+fxmarty@users.noreply.github.com>
fxmarty force-pushed the replace-np-str-by-builtin-python-str branch from 5442722 to 604ed96 Compare 
Collaborator
| Thanks for your contributions and another PR #2112 has been merged to fix this. |
Author
| Great thanks! Do you plan on making a release for it? |
Collaborator
| Sure, probably along with couple of bug fixes later. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
np.stris removed in numpy==1.24.0, and is just a redirection to builtin python str.