feat: added support for barCompleteChar being an array of string plus others associated #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ve" bar complete characters feat(preset): added preset for Docker-CLI-style unicode braille pattern dot characters refactor(options): updated `parse` to use computed property for instance-specific options (`barCompleteString`, `barIncompleteString`, and `autopaddingChar`) refactor(options): dropped `assignDerivedOptions` for computed properties refactor: updated usage of functions in `options` in other functions refactor: renamed imports for intuitiveness refactor: added `.js` back to import paths test(formatter): updated how defaults are propagated to individual tests test(braille-patterns): added test for braille pattern preset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
I have been tinkering to add a "segmented" progress bar (as suggested in #129) into this library. I realize it needs a more condensed way to represent "progress" for such a bar to be legible in the process. I have thus taken the time and inspiration from the Docker CLI and implemented support for multiple complete characters and a preset for braille pattern dot unicode characters.
Commit Message
feat(formatter): updated bar formatter to support multiple "progressive" bar complete characters
feat(preset): added preset for Docker-CLI-style unicode braille pattern dot characters
refactor(options): updated
parseto use computed property for instance-specific options (barCompleteString,barIncompleteString, andautopaddingChar)refactor(options): dropped
assignDerivedOptionsfor computed propertiesrefactor: updated usage of functions in
optionsin other functionsrefactor: renamed imports for intuitiveness
refactor: added
.jsback to import pathstest(formatter): updated how defaults are propagated to individual tests
test(braille-patterns): added test for braille pattern preset