fix: fix parsing for newer versions of brotli #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Newer versions of brotli have changed how it defines version macros in `c/common/version.h`. Attempt to decode the new definitions first, falling back to the previous code to allow the parser to parse the version from both older and newer versions of brotli.
| FWIW: $ cd dep_checker $ python3 Python 3.11.6 (main, Oct 3 2023, 00:00:00) [GCC 12.3.1 20230508 (Red Hat 12.3.1-1)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from pathlib import Path >>> import versions_parser >>> versions_parser.get_brotli_version(Path("/home/rlau/sandbox/github/node")) '1.1.0' >>> versions_parser.get_brotli_version(Path("/home/rlau/sandbox/github/trees/v20.x")) '1.0.9' >>> |
RafaelGSS approved these changes Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Newer versions of brotli have changed how it defines version macros in
c/common/version.h. Attempt to decode the new definitions first, falling back to the previous code to allow the parser to parse the version from both older and newer versions of brotli.Fixes: nodejs/security-wg#1181