Type hinting overhaul. #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Kircheneer force-pushed the typing-overhaul branch from 5b1f7c1 to 5a3bf7b Compare Kircheneer force-pushed the typing-overhaul branch 2 times, most recently from 70336ac to b0dcde9 Compare 
| """Exception raised when trying to store a DiffSyncModel or DiffElement that is already being stored.""" | ||
| | ||
| def __init__(self, message, existing_object, *args, **kwargs): | ||
| def __init__(self, message: str, existing_object: Union["DiffSyncModel", "DiffElement"], *args: Any, **kwargs: Any): |
There was a problem hiding this comment.
Should existing_object just be an Any?
There was a problem hiding this comment.
What other than DiffSyncModel or DiffElement would we store in a store?
Kircheneer force-pushed the typing-overhaul branch from b0dcde9 to 862fea9 Compare Kircheneer force-pushed the typing-overhaul branch from 862fea9 to 75b6b19 Compare 
| Addressed all outstanding comments, rebased against develop and put it into a backwards-compatible state. Should be an easy-ish merge at this point I think? |
Kircheneer force-pushed the typing-overhaul branch from 75b6b19 to acea842 Compare 
Kircheneer force-pushed the typing-overhaul branch from acea842 to 4fa39b5 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #175. Things that happened here:
disallow_untyped_defsin mypy config inpyproject.tomlMappingwithDict,CollectionwithListandTextwithstr, because all our mappings are dicts anyway, collections are lists (3.9 could usedict/list, maybe we can drop 3.8 support with 2.0?) andTextis only needed for backwards compatibility with Python 2.x which we aren't offering