Fixed #20950: Add missing module and device properties in module-bay #21005
Conversation
kprince28 changed the title 
jnovinger requested review from a team and jnovinger and removed request for a team 
| installed_module = ModuleSerializer( | ||
| nested=True, | ||
| fields=('id', 'url', 'display', 'serial', 'description'), | ||
| fields=('id', 'url', 'display', 'device', 'module_bay'), |
There was a problem hiding this comment.
Why did we lose serial and description here?
There was a problem hiding this comment.
because I just follow the API specification in this API, so serial and description are not present in the API spec.
There was a problem hiding this comment.
Understood. Unfortunately, removing fields from an API serializer like this is a breaking change that will need to be present in a minor release, as opposed to this, which will ship in a patch release.
It's also very possible that those fields were intended to be there all along and that the OpenAPI schema that's being generated is just incorrect.
Please restore these fields in this PR. We will need to follow up on this in a new issue. If you have a moment, we would very much appreciate if you could file a bug for this.
2 participants
Fixes: #20950