Enhance Web Worker federation runtime support #4116
+4,077 −1,483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- reassign non-initial entrypoints to their own runtime when runtimeChunk is single or object form - add worker demo and cypress assertion covering the web worker bootstrap
🦋 Changeset detectedLatest commit: 4a375c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @codex harshly review the changes here. not completly happy with the solutions applied here. do lots of research and give review comments |
| Summary
Testing
|
| @codex harshly review pr |
| Summary
Testing
|
| @ScriptedAlchemy this will fix any references to modules via I'm asked because we use custom Worker constructor :/ |
| Any chance you can send a PR or branch and modify one of our apps in /apps to replicate your needs so I can run against that app within this monorepo |
- Add comprehensive test for webpack worker compilation with Module Federation - Test verifies worker syntax new Worker(new URL()) compiles correctly - Validates federated modules (React, ComponentA) are accessible in worker context - Tests both CommonJS (async-node) and ESM (node14) module outputs - Provides URL to test scope via moduleScope for Node.js targets - All 10 tests pass successfully (5 tests × 2 builds)
Added beforeEach hook to reset React version to '0.1.2' before running worker tests. This prevents test contamination from other container tests (like 1-container-full) that set React version to '3.2.1' and cause the worker test to fail with unexpected version mismatches. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
… cross-context relocation Enhanced runtime chunk detection and federation runtime injection to properly support worker threads. Added safeguards to prevent runtime module relocation between different execution contexts (main thread vs workers). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ker demo - Enable runtimeChunk in webpack config to ensure bundler runtime is available - Update WorkerDemo to use WorkerWrapper instead of module worker - This fixes the 'bundler runtime is required to load remote chunk' error in workers
…tion fix Added and updated tests to verify the stage 40 fix for EmbedFederationRuntimeModule: - Updated FederationRuntimePluginWorkerRuntime.test.ts to verify runtime module execution order in worker bundles (EmbedFederation appears AFTER StartupChunkDependencies) - Updated FederationRuntimePluginHostRuntime.test.ts to add test for main bundle generation with correct runtime module order - Created HoistContainerReferencesPlugin.test.ts with 13 comprehensive tests covering: - Plugin application and hook registration - Runtime chunk detection - Module hoisting for container entries, federation runtime, and worker runtime - Chunk cleanup - getAllReferencedModules helper function with various traversal types - Updated RemoteRuntimeModule.test.ts to include defensive initialization lines All 632 tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…rder Refactored both FederationRuntimePlugin compiler-unit tests to use programmatic webpack execution instead of spawning webpack-cli: - FederationRuntimePluginHostRuntime.test.ts: - Removed swc-loader dependency by using plain JavaScript - Changed to use programmatic webpack API (runWebpack helper) - Adjusted first test to expect successful build (not error) - Changed second test to use development mode to preserve markers - Updated assertions to check for actual functional code - FederationRuntimePluginWorkerRuntime.test.ts: - Fixed ROOT path calculation (was off by one level) All tests now pass successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed FederationRuntimePluginWorkerRuntime.test.ts by: - Removed `plugin._options.remotes = {}` which was causing module resolution errors - Fixed collectInfrastructureErrors to handle non-iterable entries properly - Simplified error checking to log errors for debugging The test was failing because it removed all remotes, but the source code imports from remote1 modules (WebpackSvg, WebpackPng, useCustomRemoteHook). The build now succeeds by keeping the remotes configuration intact. All 73 container tests now pass. Fixed Next.js e2e tests failing with "__webpack_require__.f is undefined" by changing the execution order in EmbedFederationRuntimeModule: **Before:** 1. Require federation entry 2. Call prevStartup() **After:** 1. Call prevStartup() - initializes webpack runtime handlers 2. Require federation entry - handlers are now available The federation entry imports modules that depend on webpack runtime handlers like __webpack_require__.f.consumes. By calling prevStartup first, we ensure all these handlers are registered before the federation entry is required. This fixes the error: "Cannot read properties of undefined (reading 'consumes')" at __webpack_require__.f.consumes Also changed stage from 40 to 30 to run earlier in the initialization sequence while still being after StartupChunkDependenciesRuntimeModule (stage 20).
Changes: - Simplified EmbedFederationRuntimeModule to load federation entry at STAGE_NORMAL - Removed stub bundlerRuntime approach (caused merging issues with prevFederation) - Updated Cypress configs to use CI env variable for retry logic (0 locally, 2-3 in CI) - Created run-next-e2e.mjs script for local Next.js e2e testing - Added RUNTIME_INIT_FIX.md documentation explaining the stage ordering issue - Deleted unused ChildCompilationRuntimePlugin.ts Known Issue: Next.js SSR still has 500 errors during page rendering. The federation entry loads correctly in client bundles but server bundles may need investigation. 🤖 Generated with Claude Code https://claude.com/claude-code Co-Authored-By: Claude <noreply@anthropic.com>
…tialization Fixes worker runtime initialization while maintaining Next.js compatibility by detecting chunk loading type and applying appropriate runtime module stages. - JSONP chunks (Next.js): STAGE_ATTACH (10) - loads inside startup hook - Worker chunks (import-scripts): STAGE_BASIC (5) - loads immediately before RemoteRuntimeModule - Follows webpack's pattern from JsonpChunkLoadingPlugin for chunk type detection - Adds comprehensive unit tests for stage selection logic Resolves initialization timing issues where bundlerRuntime was undefined when RemoteRuntimeModule tried to access it in worker environments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
… pattern Updates FederationRuntimePluginWorkerRuntime test to reflect the new implementation where worker chunks use immediate execution (stage 5) instead of startup hook wrapper pattern. - Removes checks for old startup hook pattern (prevStartup wrapper) - Verifies federation runtime module is present - Validates federation entry is loaded regardless of execution pattern 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
| @codex review pr deeply |
| Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
ScriptedAlchemy changed the title Remove RUNTIME_INIT_FIX.md as it's internal documentation that shouldn't be in the codebase. The changeset documentation is sufficient for release notes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Adds defensive checks for bundlerRuntime existence before calling remotes() in RemoteRuntimeModule. This prevents TypeError when HMR chunks (like react-refresh-webpack-plugin vendors) are loaded that don't have the federation runtime injected. Fixes blob-based worker HMR scenario reported in issue #4085 where bundlerRuntime.remotes would be undefined in dynamically loaded chunks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Removes the id-token: write permission requirement that was causing workflow validation errors due to permission restrictions in called workflows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Resolves #4085.