Skip to content

fix: menu button narration #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: menu button narration #3465

wants to merge 1 commit into from

Conversation

@gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Sep 6, 2025

Closes #3376

PR Type

  • Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • Accessibility tested and approved
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information
@gavinbarron gavinbarron requested a review from a team as a code owner September 6, 2025 00:00
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 6, 2025

Thank you for creating a Pull Request @@gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)
@github-actions
Copy link

github-actions bot commented Sep 6, 2025

📖 The updated storybook is available here
@gavinbarron
Copy link
Member Author

gavinbarron commented Sep 8, 2025

@vagpt please validate the proposed fix available here: https://mgt.dev/next/pr/3465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build: Storybook

2 participants

@gavinbarron