Skip to content

Conversation

@ahnsv
Copy link
Contributor

@ahnsv ahnsv commented Nov 18, 2018

…ence, and material ui framework added

Hey I added tslint and linting feature in package.json, and (you prob aint no need this, but) added material ui framework too. I was developing a chrome extension using your boilerplate, and I just felt like your boilerplate is awesome and very convenient, except for lacking linting feature. So I'm adding PR-ing this, but feel free to remove material ui part. 👍

Copy link
Owner

@martellaj martellaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the addition of tslint - great idea! But yeah, not so interested in the Material stuff. Can you please push a change removing that bit and I'll merge straight away!

@ahnsv
Copy link
Contributor Author

ahnsv commented Nov 19, 2018

Done! Free to go 👍

Copy link
Owner

@martellaj martellaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements here!

@martellaj martellaj merged commit aee86f5 into martellaj:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants